Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit acts_as_paranoid to be given on abstract AR classes #306

Open
wants to merge 1 commit into
base: rails4
Choose a base branch
from

Conversation

p
Copy link
Contributor

@p p commented Feb 8, 2016

@p
Copy link
Contributor Author

p commented Feb 10, 2016

CI failure seems unrelated to the changes in this PR, let me know what you want me to do about it.

@denisahearn
Copy link

My Rails app is using abstract classes with paranoia and running into the issue that this PR solves. Any chance this work can get reviewed and merged into the next release?

# triggers https://github.com/rails/rails/issues/10658 /
# https://github.com/rails/rails/issues/23413
# if default_scope is specified as a closure instead of a class method
child = ParanoidChild.first
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you asserting to not happen here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants